chore: fix fetching files in speech to text controller #274
Conversation
examples/speech-to-text/ios/speechtotext.xcodeproj/project.pbxproj
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Let's leave it now, but in future try not to include irrelevant changes like this caused by rebuilds that has nothing to do with changes mentioned in PR
There was a problem hiding this comment.
Some of the relevant changes were actually autogenerated (build)
There was a problem hiding this comment.
Yeah, changes in permissions can be autogenerated, but I see no reason to include formatting changes in kotlin in this PR. I'm not even sure why is this happening - it should have been properly formatted after expo update along with other files.
Anyway, I think these kind of changes should be limited to PRs related to bumping version of dependencies etc
| if (Platform.OS === 'android') { | ||
| const permission = await PermissionsAndroid.check( | ||
| PermissionsAndroid.PERMISSIONS.RECORD_AUDIO | ||
| ); | ||
| if (!permission) { | ||
| const granted = await PermissionsAndroid.request( | ||
| PermissionsAndroid.PERMISSIONS.RECORD_AUDIO | ||
| ); | ||
| if (granted !== PermissionsAndroid.RESULTS.GRANTED) { | ||
| console.log('Microphone permission denied'); | ||
| return; | ||
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
We're not asking for permission on ios?
There was a problem hiding this comment.
no, it's handled automatically
Description
Type of change
Tested on
Checklist